Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TLDs .dj, .gr, .np, .pa, and .vn #89

Open
jonathansampson opened this issue Feb 1, 2023 · 1 comment
Open

Support for TLDs .dj, .gr, .np, .pa, and .vn #89

jonathansampson opened this issue Feb 1, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Feb 1, 2023

Version(s) affected: 1.14.0

Description

Error: TLD <domain with one of the aforementioned TLDs> not found
    at whoisTld (whoiser.js:118:9)
    at async whoisDomain (whoiser.js:137:15)

Side Note: Phenomenal work on this utility. I reviewed a few similar options on npm, and your dedication to quality made whoiser the clear winner.

@jonathansampson jonathansampson added the bug Something isn't working label Feb 1, 2023
@AndreiIgna
Copy link
Member

this is not kinda fixed by #86

To query WHOIS for a domain, the library needs to know the WHOIS server for that TLD. It finds it in this order:

  1. cached/hard-coded whois server https://github.com/LayeredStudio/whoiser/blob/master/src/whoiser.js#L9
  2. query whois.iana.org for TLD info
  3. when no tld.whois is found, query alternate TLD sources Third Level Domains, Additional TLDs, & Bug Fixes #80

The error was returned because tld.whois was empty. Now the library doesn't throw an error, but it returns the TLD info without whois. Example for .vn:
Screenshot 2023-02-04 at 12 38 59

For cases like these, the TLD whois server needs to be found and added in the whoiser.js -> cacheTldWhoisServer variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants