Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package? #96

Open
Happypig375 opened this issue Feb 15, 2018 · 13 comments
Open

NuGet package? #96

Happypig375 opened this issue Feb 15, 2018 · 13 comments

Comments

@Happypig375
Copy link
Contributor

This looks like a wonderful project. Is a NuGet package available?
Do I need to reference the entire master branch to use Typography?

@zwcloud
Copy link
Contributor

zwcloud commented Feb 15, 2018

I think Typography hasn't reached a stable state. I personally only use an old version of Typography.GlyphLayout and Typography.OpenFont in my project, but they are also being updated.

Typography does have great potential but it needs some focus on how to release and keeping stability.

@Happypig375
Copy link
Contributor Author

Do you mean that master is not guaranteed to be stable?
I see that the update of your old version of Typography is not reflected in the link.
Can you please provide me a link to your stable Typography for me to git-submodule it?

@zwcloud
Copy link
Contributor

zwcloud commented Feb 15, 2018

@Happypig375

Do you mean that master is not guaranteed to be stable?

I'm afraid, yes, from my using experience. It just works.

Can you please provide me a link to your stable Typography for me to git-submodule it?

I copied Typography source code (only Typography.GlyphLayout and Typography.OpenFont) to my project. It was taken from b0d71cb.

@prepare
Copy link
Member

prepare commented Feb 15, 2018

@Happypig375 , Thank you for your interested.


that master is not guaranteed to be stable?

That's right,
Each master branch should be usable but
The API may be changed some points from each master release.

and It will be changed again soon (about how to layout/measure string).


so No Nuget for now, please use it at source level.

see samples at ...

https://github.com/LayoutFarm/Typography/tree/master/

You don't need to reference all of the reference the entire master branch.

If you want the read a font file.
You need only Typography.OpenFont and Typography.GlyphLayout.

I provide an simple example here.

https://github.com/LayoutFarm/Typography/tree/master/Demo/Windows/GdiPlusSample.WinForms


@Happypig375
Copy link
Contributor Author

Is there any indication of a stable commit?
I don't want to stay outdated.

@samhocevar
Copy link
Contributor

samhocevar commented Feb 16, 2018

My strategy is to test a specific version and stick to it; in my project (Emoji.Wpf) I am using a commit from 3 months ago, before the big glyph layout refactoring.

@Happypig375
Copy link
Contributor Author

I suggest using a development branches to avoid unstable master branch.

Like this:
master - stable
dev - heavy development

The dev branch will be merged into master once in a while when it is stable enough.

@ForNeVeR
Copy link

Hey, guys, it's actually okay to publish some preview/unstable packages if you're unsure about the API stability. It will make it easier to depend on the preview bits of the library.

Also, keep in mind that (AFAIK) semver allows you to break compatibility in pre-1.0 versions.

@charlesroddie
Copy link

@prepare Can you do this officially? Unstable API is no problem.

If not, do you object to anyone else publishing to nuget? In that case stating that it is both unstable and unofficial?

Thanks.

@Happypig375
Copy link
Contributor Author

Imo, the rate of bugs being found justifies using Typography as a git submodule.
Every time a bugfix is done, updating the submodule is faster than publishing to NuGet, then download and stuff.

@charlesroddie
Copy link

Is the stability of Typography improving? Could a nuget package be in sight?

@charlesroddie
Copy link

Does Typography need to be forked to get a nuget package out?

@casperOne
Copy link

Given the existence of github actions, a commit to master is all that's required to push a new release to NuGet.

And, to be frank, NuGet is the standard for distributing modules in the .NET ecosystem.

That said, given that the last commit seems to have been nine months ago could we:

a) Have an official release to NuGet: I'd be happy to set up the actions (it would be a PR), all that's needed on the part of @Happypig375 is to set up the NuGet account and put the secrets in the repo (the developers would never have to see those secrets)
b) Give a blessing to a fork of the project to publish to NuGet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants