[3/N] Chunk encoding optimization: Add support of new encoding format… #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxue-l2
approved these changes
Jul 11, 2024
api/proto/node/node.proto
Outdated
| @@ -54,6 +54,14 @@ message RetrieveChunksRequest { | |||
| message RetrieveChunksReply { | |||
| // All chunks the Node is storing for the requested blob per RetrieveChunksRequest. | |||
| repeated bytes chunks = 1; | |||
| // Describes how the chunks above are encoded. | |||
| // If not specified, it’s treated as GOB. | |||
There was a problem hiding this comment.
if unspecified, wouldn't it be the first definition in enum, which is unknown
There was a problem hiding this comment.
We need to default to GOB in order to be backward compatible
There was a problem hiding this comment.
Actually it's fine to default o UNKNOWN -- we just need to make sure the GOB is set when we return GOB encoded chunks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in API
Why are these changes needed?
To handle a different format of chunk encoding.
Checks