Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit circle #945

Open
4 tasks done
WaleedTayeb opened this issue Jul 14, 2019 · 2 comments · May be fixed by #964
Open
4 tasks done

Unable to edit circle #945

WaleedTayeb opened this issue Jul 14, 2019 · 2 comments · May be fixed by #964

Comments

@WaleedTayeb
Copy link

  • I'm reporting a bug, not asking for help
  • I've looked at the documentation to make sure the behaviour is documented and expected
  • I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
  • I've searched through the issues to make sure it's not yet reported

How to reproduce

  • Leaflet version I'm using: 1.5.1
  • Leaflet Draw version I'm using: 1.04
  • Browser (with version) I'm using: Chrome v.75
  • OS/Platform (with version) I'm using: MacOS 10.14.4
  • Create a circle
  • Edit the circle by adjusting the edit circle handle.

What behaviour I'm expecting and which behaviour I'm seeing

Expecting

  • The circle should increase or decrease in size.

What I see:
image

What I propose as the fix:
Radius is not defined in this line: https://github.com/Leaflet/Leaflet.draw/blob/develop/src/edit/handler/Edit.Circle.js#L31

I propose declaring the variable in order to avoid this error
var radius;
in this line: https://github.com/Leaflet/Leaflet.draw/blob/develop/src/edit/handler/Edit.Circle.js#L25

@ilan-deepreach ilan-deepreach linked a pull request Oct 17, 2019 that will close this issue
@poet-of-the-fall
Copy link

I think it was a missing variable declaration, should be fixed with this PR: #1053

@Luperco
Copy link

Luperco commented Jul 18, 2023

Unfortunately this seems a dead project. Stopped since 2018 with over 80 active PR but there is no user with write access to approve and merge them :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants