Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: variable LEAN_SESSION_EXPIRATION is not utilized by the app #2821

Closed
ilias-sp opened this issue Nov 25, 2024 · 0 comments · Fixed by #2823
Closed

[Bug]: variable LEAN_SESSION_EXPIRATION is not utilized by the app #2821

ilias-sp opened this issue Nov 25, 2024 · 0 comments · Fixed by #2823
Assignees
Labels
Bug Fixed and Staged Fixed in Master and ready to be included in the next release

Comments

@ilias-sp
Copy link
Contributor

What is your set up?

Self Hosted Server

Version

3.3.2

Describe the issue

Variable that is meant to control the session duration is not used in the application.

[user@41 LEAN] > grep -Ri LEAN_SESSION_EXPIRATION *
config/sample.env:LEAN_SESSION_EXPIRATION = 28800                    # How many seconds after inactivity should we logout?  28800seconds = 8hours
[user@41 LEAN] > 

i believe that the file that should be consuming this variable is app/Core/Configuration/laravelConfig.php , that currently contains the below block:


        /*
        |--------------------------------------------------------------------------
        | Session Lifetime
        |--------------------------------------------------------------------------
        |
        | Here you may specify the number of minutes that you wish the session
        | to be allowed to remain idle before it expires. If you want them
        | to immediately expire on the browser closing, set that option.
        |
        */

        'lifetime' => 480, //8 hours

        'expire_on_close' => false,

        /*

Reproduction steps

Not Applicable

Additional Notes

i suppose above file should be modified from:

'lifetime' => 480, //8 hours

to:

'lifetime' => env('LEAN_SESSION_EXPIRATION', 480)
@ilias-sp ilias-sp added the Bug label Nov 25, 2024
@marcelfolaron marcelfolaron linked a pull request Nov 26, 2024 that will close this issue
3 tasks
@marcelfolaron marcelfolaron added the Fixed and Staged Fixed in Master and ready to be included in the next release label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixed and Staged Fixed in Master and ready to be included in the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants