Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the code to use non-partial functions from Protolude.StringConv #45

Open
vu3rdd opened this issue Oct 2, 2020 · 0 comments
Open

Convert the code to use non-partial functions from Protolude.StringConv #45

vu3rdd opened this issue Oct 2, 2020 · 0 comments

Comments

@vu3rdd
Copy link
Contributor

vu3rdd commented Oct 2, 2020

With Protolude 0.3.0, a non-partial toS function is exposed. This breaks the build (see #44). While we can fix #44 by using toS from Protolude.Conv (which needs to be explicitly exposed), there is a good chance that it may get removed from Protolude. So, we need to look into using the non-partial text/bytestring conversion.
vu3rdd added a commit that referenced this issue Oct 2, 2020
@vu3rdd
Explicitly hide the non-partial toS and use the partial toS.
9be8aaa 
While we would prefer to use non-partial functions, this fixes the
broken build.

Added issue #45 to tackle a proper fix.
@vu3rdd vu3rdd mentioned this issue Oct 2, 2020
Merged
@vu3rdd vu3rdd mentioned this issue Mar 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vu3rdd