Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Y333/poseidon support #28

Merged
merged 47 commits into from
Sep 4, 2024
Merged

Y333/poseidon support #28

merged 47 commits into from
Sep 4, 2024

Conversation

yogh333
Copy link
Collaborator

@yogh333 yogh333 commented Aug 1, 2024

Implement #26

yogh333 added 30 commits July 5, 2024 15:51
@yogh333
Felt arithmetic operations (+, -, x, /) OK
8b6867d
@yogh333
Poseidon first implementation (ported from Lambdaclass work)
fbe7f39
@yogh333
Optimised Poseidon hash
c658481
@yogh333
Benchmarking Poseidon implementation
89e69e5
@yogh333
Poseidon: integrate mix function
7fa9bcf
@yogh333
Poseidon hasher implementation
09efb5e
@yogh333
Hash Tx v3
b08f07d
@yogh333
Fix Poseidon hash of calldata
4d04289
@yogh333
Tx hash OK on speculos but KO on device
cc54fb3
@yogh333
Tx hash OK but unoptimized mix function
39cbe4d
@yogh333
Cleanup
b77db8b
@yogh333
Tx hash OK on both speculos and device (Poseidon optimized)
bc4d15c
@yogh333
Try to optimise partial_round loop
7ab2244
@yogh333
Increase Poseidon perf with partial_round_loop
a59a0cb
@yogh333
Add shifting hash function
99ef717
@yogh333
Add UI screens
c987726
@yogh333
Implement complete Tx signature flow for Stax/Flex
63e11a6
@yogh333
Implement complete Tx signature flow for Nanos
8806d9d
@yogh333
Add apdu-generator and switch to workspace
e1b49a1
@yogh333
Generate apdu files
2a9c653
@yogh333
Add check-signature app
c483a7c
@yogh333
[check-signature] Add possibility to pass args
73ff4d1
@yogh333
[starknet] Return Tx hash along with Tx signature
a713602
@yogh333
[tests, tools] Update Ragger tests and apdu_generator
be045fb
@yogh333
[apdu-generator] Add get_pubkey apdus
2e1b070
@yogh333
Bump SDK version
80f25e1
@yogh333
[starknet] Update ragger tests
2996df4
@yogh333
[starknet] Signing hash or Poseidon computation enabled as features o…
abdedf4 
…nly + use GenericReview to display Public Key
@yogh333
[starknet] Update Ragger tests
d89b2c2
@yogh333
[starknet] Cleanup Ragger tests
51c498d
@yogh333 yogh333 mentioned this pull request Aug 1, 2024
Closed
bboilot-ledger
bboilot-ledger requested changes Aug 12, 2024
View reviewed changes
Copy link

@bboilot-ledger bboilot-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Looks almost good to me from a security angle! It's easier to review when it's rust 😄. I wrote few comments, feel free to ping me if you want to discuss about them.

starknet/src/types.rs Outdated Show resolved Hide resolved
starknet/src/transaction.rs Outdated Show resolved Hide resolved
starknet/src/main.rs Outdated Show resolved Hide resolved
starknet/src/display.rs Outdated Show resolved Hide resolved
starknet/src/transaction.rs Outdated Show resolved Hide resolved
starknet/src/transaction.rs Show resolved Hide resolved
@yogh333 yogh333 requested a review from bboilot-ledger August 21, 2024 14:38
bboilot-ledger
bboilot-ledger previously approved these changes Aug 21, 2024
View reviewed changes
@yogh333 yogh333 merged commit 1788c02 into develop Sep 4, 2024
33 checks passed
@yogh333 yogh333 deleted the y333/poseidon_support branch September 4, 2024 07:34
@franciszekjob franciszekjob mentioned this pull request Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboilot-ledger bboilot-ledger bboilot-ledger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yogh333 @bboilot-ledger