From a535836f0ed0436ced11ba60ae903e48b4186e11 Mon Sep 17 00:00:00 2001 From: OleksiiM Date: Thu, 9 Jan 2025 13:28:24 +0000 Subject: [PATCH] rename TransactionEstimate to TransactionOptions --- libs/ledger-live-common/src/families/aptos/api/index.ts | 8 ++++---- .../src/families/aptos/buildTransaction.test.ts | 4 ++-- libs/ledger-live-common/src/families/aptos/logic.ts | 4 ++-- libs/ledger-live-common/src/families/aptos/types.ts | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/libs/ledger-live-common/src/families/aptos/api/index.ts b/libs/ledger-live-common/src/families/aptos/api/index.ts index fcea7b785bd0..3f7aa5bf2704 100644 --- a/libs/ledger-live-common/src/families/aptos/api/index.ts +++ b/libs/ledger-live-common/src/families/aptos/api/index.ts @@ -22,7 +22,7 @@ import BigNumber from "bignumber.js"; import isUndefined from "lodash/isUndefined"; import { APTOS_ASSET_ID } from "../constants"; import { isTestnet } from "../logic"; -import type { AptosTransaction, TransactionEstimate } from "../types"; +import type { AptosTransaction, TransactionOptions } from "../types"; import { GetAccountTransactionsData, GetAccountTransactionsDataGt } from "./graphql/queries"; import { GetAccountTransactionsDataQuery, @@ -85,7 +85,7 @@ export class AptosAPI { async generateTransaction( address: string, payload: InputEntryFunctionData, - options: TransactionEstimate, + options: TransactionOptions, ): Promise { const opts: Partial = {}; if (!isUndefined(options.maxGasAmount)) { @@ -97,8 +97,8 @@ export class AptosAPI { } try { - const ts = (await this.aptosClient.getLedgerInfo()).ledger_timestamp; - opts.expireTimestamp = Number(Math.ceil(+ts / 1_000_000 + 2 * 60)); // in milliseconds + const { ledger_timestamp } = await this.aptosClient.getLedgerInfo(); + opts.expireTimestamp = Number(Math.ceil(+ledger_timestamp / 1_000_000 + 2 * 60)); // in milliseconds } catch (_) { // skip } diff --git a/libs/ledger-live-common/src/families/aptos/buildTransaction.test.ts b/libs/ledger-live-common/src/families/aptos/buildTransaction.test.ts index 83945a1d5d37..c65ab1af1b41 100644 --- a/libs/ledger-live-common/src/families/aptos/buildTransaction.test.ts +++ b/libs/ledger-live-common/src/families/aptos/buildTransaction.test.ts @@ -4,7 +4,7 @@ import buildTransaction from "./buildTransaction"; import { AptosAPI } from "./api"; import { normalizeTransactionOptions } from "./logic"; import { InputEntryFunctionData } from "@aptos-labs/ts-sdk"; -import { TransactionEstimate } from "./types"; +import { TransactionOptions } from "./types"; const generateTransaction = jest.fn(() => "tx"); @@ -43,7 +43,7 @@ describe("buildTransaction Test", () => { expect(mockedNormalizeTransactionOptions).toHaveBeenCalledTimes(1); expect(generateTransaction).toHaveBeenCalledTimes(1); - const generateTransactionArgs: [string, InputEntryFunctionData, TransactionEstimate][] = + const generateTransactionArgs: [string, InputEntryFunctionData, TransactionOptions][] = generateTransaction.mock.calls[0]; expect(mockedNormalizeTransactionOptions.mock.calls[0][0]).toEqual({ diff --git a/libs/ledger-live-common/src/families/aptos/logic.ts b/libs/ledger-live-common/src/families/aptos/logic.ts index 8b314831e7e7..bd1ed2c41ad8 100644 --- a/libs/ledger-live-common/src/families/aptos/logic.ts +++ b/libs/ledger-live-common/src/families/aptos/logic.ts @@ -16,7 +16,7 @@ import { DIRECTION, TRANSFER_TYPES, } from "./constants"; -import type { AptosTransaction, TransactionEstimate } from "./types"; +import type { AptosTransaction, TransactionOptions } from "./types"; export const DEFAULT_GAS = 200; export const DEFAULT_GAS_PRICE = 100; @@ -38,7 +38,7 @@ export const getMaxSendBalance = ( return amount.gt(totalGas) ? amount.minus(totalGas) : new BigNumber(0); }; -export function normalizeTransactionOptions(options: TransactionEstimate): TransactionEstimate { +export function normalizeTransactionOptions(options: TransactionOptions): TransactionOptions { const check = (v: any) => ((v ?? "").toString().trim() ? v : undefined); return { maxGasAmount: check(options.maxGasAmount), diff --git a/libs/ledger-live-common/src/families/aptos/types.ts b/libs/ledger-live-common/src/families/aptos/types.ts index 048afef95dfa..ccd393acf81d 100644 --- a/libs/ledger-live-common/src/families/aptos/types.ts +++ b/libs/ledger-live-common/src/families/aptos/types.ts @@ -38,7 +38,7 @@ export type AptosAddress = { path: string; }; -export interface TransactionEstimate { +export interface TransactionOptions { maxGasAmount: string; gasUnitPrice: string; } @@ -52,7 +52,7 @@ export type Transaction = TransactionCommon & { mode: string; family: "aptos"; fees?: BigNumber | null; - estimate: TransactionEstimate; + estimate: TransactionOptions; errors?: TransactionErrors; tag?: string; };