Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BACK-7924): improve error handling #134

Merged
merged 14 commits into from
Nov 4, 2024
Merged

feat(BACK-7924): improve error handling #134

merged 14 commits into from
Nov 4, 2024

Conversation

jnicoulaud-ledger
Copy link
Contributor

  • improve output for some particular errors (HTTP responses, addresses used instead of paths)
  • sanitize pydantic errors
  • customize errors for specific types (path, base types, unions)
  • sort and deduplicate linter outputs
  • minor wording improvements

This fixes bad error output in LedgerHQ/clear-signing-erc7730-registry#33

@jnicoulaud-ledger
feat(BACK-7924): improve HTTP client errors
3b7b4f2
@jnicoulaud-ledger
feat(BACK-7924): define pydantic annotation to customize errors
02acda6
@jnicoulaud-ledger
feat(BACK-7924): define pydantic annotation to customize errors / con…
0646319 
…text manager
@jnicoulaud-ledger
feat(BACK-7924): use context manager to catch pydantic errors
68d87a6
@jnicoulaud-ledger
feat(BACK-7924): remove unnecessary error wrapping
b6e2ef7
@jnicoulaud-ledger
feat(BACK-7924): improve/fix linters error messages
f1ab33a
@jnicoulaud-ledger
feat(BACK-7924): customize error type labels for paths
86d9ecf
@jnicoulaud-ledger
feat(BACK-7924): fix nativeCurrencyAddress bad management of descript…
6ba14d8 
…or paths
@jnicoulaud-ledger
feat(BACK-7924): add constraints on intent
76b3c98
@jnicoulaud-ledger
feat(BACK-7924): add more custom error type labels
bb59560
@jnicoulaud-ledger
feat(BACK-7924): detect constant addresses and print errors
ef3538d
@jnicoulaud-ledger
feat(BACK-7924): use new stuff for linter
05aa868
@jnicoulaud-ledger
feat(BACK-7924): update/add tests
8ec4f20
@jnicoulaud-ledger jnicoulaud-ledger requested a review from a team as a code owner November 4, 2024 10:06
@jnicoulaud-ledger jnicoulaud-ledger merged commit d1b2867 into main Nov 4, 2024
5 checks passed
@jnicoulaud-ledger jnicoulaud-ledger deleted the BACK-7924 branch November 4, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamier fsamier fsamier approved these changes

Assignees
No one assigned
Labels
sources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnicoulaud-ledger @fsamier