Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARCHER2 fixes from MOSRS (includes all changes) #38

Closed
wants to merge 10 commits into from

Conversation

leifdenby
Copy link
Collaborator

This pull-request represents all changes on branches/dev/adrianhill/r8166_archer2_fix on MOSRS relative to our master branch

adrianhill and others added 10 commits February 11, 2021 12:26
Created /main/branches/dev/adrianhill/r8166_archer2_fix from /main/trunk@8166.


git-svn-id: https://code.metoffice.gov.uk/svn/monc/main/branches/dev/adrianhill/r8166_archer2_fix@8430 0f676ef4-b20c-4647-9485-21614760d15f
… 64, add ffte compile options to monc-build to force bit comparability, remove logging=4 from test-harness continuation script

git-svn-id: https://code.metoffice.gov.uk/svn/monc/main/branches/dev/adrianhill/r8166_archer2_fix@8444 0f676ef4-b20c-4647-9485-21614760d15f
@leifdenby
Copy link
Collaborator Author

leifdenby commented Feb 11, 2021

The good news is that this compiles and runs in single-core ubuntu (CI test passed). The challenge is that it includes many more things besides just fixes for ARCHER2 (because this was branched from trunk on MOSRS and not from a tagged version). I will need to go through and find the changes that we need.

@leifdenby leifdenby mentioned this pull request Feb 17, 2021
@cemac-ccs
Copy link
Collaborator

cemac-ccs commented Mar 26, 2021

Am I right in thinking that the first commit in this list comprises all the Reading changes to bring Leeds-MONC level with the HEAD of MOSRS and so can be ignored for the time being (with the obvious exception of where the archer2 changes and Reading changes intersect)?

@cemac-ccs
Copy link
Collaborator

Have gone through the commits, and if numbering the list of commits on this ticket from the top then the list of commits which are needed to run the Leeds branch without casim or socrates on Archer2 are commits 3,4,5,7 and 10. Commit 1 seems to be the Reading mega-change, commit 2 is changes to code that only exists on the trunk or if commit 1 has been merged in. Parts of commits 4 and 8 may be needed and I am unsure of commit 9 - more testing with casim and socrates will hopefully shed light on this.

I expect to have a PR ready for review soon once I have tried running bomex with casim, socrates and both casim and socrates.

@leifdenby
Copy link
Collaborator Author

I'm closing this because it is being superseded by #45

@leifdenby leifdenby closed this Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants