Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitations? #5

Open
yairchu opened this issue Dec 30, 2021 · 2 comments
Open

Limitations? #5

yairchu opened this issue Dec 30, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@yairchu
Copy link

yairchu commented Dec 30, 2021

It would be helpful for the readme to specify limitations.
For example I tried lance on the following example program and it broke it:

class Solution:
    def part1(self):
        print("AOC 1 Part 1")
    def part2(self):
        print("AOC 1 Part 2")

sol = Solution()
for i in [1, 2]:
    getattr(sol, f"part{i}")()
@LeviBorodenko LeviBorodenko added the bug Something isn't working label Dec 30, 2021
@yairchu
Copy link
Author

yairchu commented Dec 30, 2021

I think that to fully support the dynamic getattrs that Python allows would be almost impossible?

@LeviBorodenko
Copy link
Owner

LeviBorodenko commented Dec 30, 2021

Indeed. Now that I see the issue with the above example, I think that no static code analysis based approach will fix these. A limitation section in the readme would be appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants