Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unauthenticated users cannot see reservation details #444

Open
gitthismoney opened this issue Oct 17, 2024 · 3 comments
Open

Unauthenticated users cannot see reservation details #444

gitthismoney opened this issue Oct 17, 2024 · 3 comments

Comments

@gitthismoney
Copy link

Hello,

We are testing the latest release and I ran in to an issue.

We typically allow unauthenticated users to browse the schedule with full reservation details so we can display Resource Calendar on a tv.

On the latest release, unauthenticated users are not able to see full reservation details. They only see the booked times, but no title, owner or desc. I attached a screenshot as example.

If I highlight one of the bookings, it does tell me which room is booked... but I also receive a red message:
Can't see reservation details because you don't have permissions to any of the resources in this reservation

my config.php
$conf['settings']['privacy']['view.schedules'] = 'true';
$conf['settings']['privacy']['view.reservations'] = 'true';
$conf['settings']['privacy']['hide.user.details'] = 'true';
$conf['settings']['privacy']['hide.reservation.details'] = 'false';
$conf['settings']['privacy']['allow.guest.reservations'] = 'false';

Screen Shot 2024-10-17 at 1 50 05 PM

Wondering if i've missed something?

Thank you,

@gitthismoney
Copy link
Author

Update, i tested an earlier release librebooking-2.8.6.zip

This release is not affected by the issue

@treborin
Copy link
Contributor

Update, i tested an earlier release librebooking-2.8.6.zip

This release is not affected by the issue

Pls., @gitthismoney , close this issue

@tkasch
Copy link

tkasch commented Jan 21, 2025

Please don't close this issue without fixing it. Similar to @gitthismoney, we rely on schedule details to be visible for unauthenticated users as well at our site. Since this has worked perfectly for us until version 2.8.6, I'd consider this issue a regression.

I stumbled across this problem back in September 2024 when trying to update (a copy of) our production site in order to do a quick test if LibreBooking supports PHP >= 8.2. Unfortunately, I haven't had the resources to dig into this yet.

For me, such a fundamental change of functionality in a sub-micro-version update (from 2.8.6 to 2.8.6.2) came quite unexpected and IMHO would have justified a minor version bump (at least) as well as an explicit hint in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants