You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The image used in torch 1.x is built from dockers/ubuntu-cuda/Dockerfile and all required dev packages listed in requirements/_devel.txt are installed in advance
However, the image used in torch 2.x is a vanilla pytorch image which contains no dev packages required to build and test torchmetrics. As a result, even if a package is added in the corresponding .txt file in requirements directory, the image does not pick up the change and fails the build and check
To Reproduce
In my case,
add a new package in a .txt file under requirements directory
update the pull request to trigger the integration check which depends on torch 2.x image
Code sample
e.g. in requirements/image.txt, add kornia >=0.6.7, <0.7.1
Expected behavior
the images install packages according to the .txt files in requirements directory
Environment
TorchMetrics version (and how you installed TM, e.g. conda, pip, build from source): 1.3.0dev
Python & PyTorch Version (e.g., 1.0): 3.9.18 / 2.1.1+cu121
Any other relevant information such as OS (e.g., Linux): Debian GNU/Linux 12 (bookworm)
Additional context
The text was updated successfully, but these errors were encountered:
@ywchan2005 thank you for your question; for integration, we would like to use only images with vanilla pytorch. Still, we faced recently breaking changes on Azure DevOps, such as any image used in workflows has to support node 20+, which means Ubuntu 20+, and the needed torch torch1.13 image is based on legacy Ubuntu 18, so we had to replace it...
@Borda thanks for the reply. I'm in the middle of a pull request, and struggling how to move forward due to the errors raised in the integration pipeline which blocks the review process.
I'm in the middle of a pull request, and struggling how to move forward due to the errors raised in the integration pipeline which blocks the review process.
Have you already opened the PR? then we can see together where the problem is...
🐛 Bug
In
.azure/gpu-integrations.yml
, two different images are used for torch 1.x and 2.xpytorchlightning/torchmetrics:ubuntu22.04-cuda11.8.0-py3.9-torch1.13
pytorch/pytorch:2.1.1-cuda12.1-cudnn8-runtime
The image used in torch 1.x is built from
dockers/ubuntu-cuda/Dockerfile
and all required dev packages listed inrequirements/_devel.txt
are installed in advanceHowever, the image used in torch 2.x is a vanilla pytorch image which contains no dev packages required to build and test torchmetrics. As a result, even if a package is added in the corresponding
.txt
file inrequirements
directory, the image does not pick up the change and fails the build and checkTo Reproduce
In my case,
.txt
file underrequirements
directoryCode sample
e.g. in
requirements/image.txt
, addkornia >=0.6.7, <0.7.1
Expected behavior
the images install packages according to the
.txt
files inrequirements
directoryEnvironment
conda
,pip
, build from source): 1.3.0devAdditional context
The text was updated successfully, but these errors were encountered: