Implement gadgets in the backend #33
Conversation
konsumlamm
force-pushed
the
gadgets
branch
2 times, most recently
from
3dc1405
to
a1adb3d
Compare
konsumlamm
requested review from
Comeza and
TrueDoctor
and removed request for
Comeza
Determine gadgets based on team Add `Gadget` element
Check if gadget has already been used Use more functions More warnings
konsumlamm
added
enhancement
| pub enum MrXGadget { | ||
| AlternativeFacts { stop_id: String }, | ||
| Midjourney { image: Vec<u8> }, | ||
| NotFound, | ||
| Teleport, | ||
| Shifter, | ||
| } | ||
|
|
||
| #[derive(specta::Type, Clone, Serialize, Deserialize, Debug)] | ||
| pub enum DetectiveGadget { | ||
| Stop { stop_id: String }, | ||
| OutOfOrder, | ||
| Shackles, | ||
| } |
There was a problem hiding this comment.
What would speak against using just one enum? You could add a function is_usable_by(team: Team) -> bool
There was a problem hiding this comment.
The main advantage is that it's harder for the frontend to accidentally send a gadget from the wrong team. Using a single enum might be cleaner though.
There was a problem hiding this comment.
Another advantage is that there are separate countdowns for Mr. X and Detective gadgets.
| #[derive(Debug)] | ||
| pub struct GadgetState<T> { | ||
| can_be_used: bool, | ||
| cooldown: Option<f32>, |
There was a problem hiding this comment.
I think it would be cleaner to use chrono::DateTime<Utc>.
There was a problem hiding this comment.
The cooldown is the number of seconds remaining, using a DateTime<Utc> requires more work to get the remaining time each iteration.
| MrXGadget(MrXGadget), | ||
| DetectiveGadget(DetectiveGadget), | ||
| MrXPosition(MrXPosition), |
There was a problem hiding this comment.
If we add more gadget this might become cluttered, thus you might want to wrap this in a UseGadget(Gadget)
Part of #31.