Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up local and CI environments #421

Open
bgins opened this issue Oct 31, 2024 · 0 comments
Open

Clean up local and CI environments #421

bgins opened this issue Oct 31, 2024 · 0 comments
Assignees

Comments

@bgins
Copy link
Contributor

bgins commented Oct 31, 2024

Our current method for setting environment variables for CI and local development are a bit entangled. For example, we set the DISABLE_TELEMETRY in our test workflow here:

- name: Run stack
env:
DISABLE_TELEMETRY: true
run: ./stack compose-up -d

But the compose-up command overrides the variable by calling compose-env:

lilypad/stack

Lines 33 to 37 in c2c4a11

function compose-up() {
load-local-env
compose-env
docker compose -f ./docker/docker-compose.dev.yml up "$@"
}

lilypad/stack

Lines 11 to 14 in c2c4a11

function compose-env() {
export ADMIN_ADDRESS=${@:-"0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266"}
export DISABLE_TELEMETRY=false
}

Let's do a quick audit to clean up these environments and separate the local development and CI environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants