Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpunit-core should not require Drupal installation #38

Open
mradcliffe opened this issue Aug 7, 2015 · 1 comment
Open

phpunit-core should not require Drupal installation #38

mradcliffe opened this issue Aug 7, 2015 · 1 comment
Labels
bug
Milestone
1.6.0

Comments

@mradcliffe
Copy link

Running phpunit tests should not require a Drupal installation as there should be no database state for those tests. It should only need to download Drupal.

Solution should be to decouple download and install tasks from the ensure drupal and ensure module functions.
@LionsAd
Copy link
Owner

LionsAd commented Aug 7, 2015

That is correct and I missed that the installation is done, too for phpunit-core. I usually used the phpunit runner with a dependency on drupal/drupal myself in cases where I only use tests in a dedicated tests directory, but I agree phpunit-core needlessly does that.

Thanks for the bug report!

@LionsAd LionsAd added the bug label Aug 7, 2015
@LionsAd LionsAd added this to the 1.5.0 milestone Aug 7, 2015
mradcliffe added a commit to mradcliffe/drupal_ti that referenced this issue Aug 8, 2015
@mradcliffe
Issue LionsAd#38: Decouple download and installation of Drupal core a…
aeb0e05 
…nd modules.
mradcliffe added a commit to mradcliffe/drupal_ti that referenced this issue Aug 8, 2015
@mradcliffe
Issue LionsAd#38: Add missing change directory for phpunit-core runner
729b806
mradcliffe added a commit to mradcliffe/drupal_ti that referenced this issue Sep 8, 2015
@mradcliffe
Issue LionsAd#38: Decouple download and installation of Drupal core a…
aa5ddf2 
…nd modules.
mradcliffe added a commit to mradcliffe/drupal_ti that referenced this issue Sep 8, 2015
@mradcliffe
Issue LionsAd#38: Add missing change directory for phpunit-core runner
f46f787
@LionsAd LionsAd modified the milestones: 1.5.0, 1.6.0 Dec 12, 2015
yanniboi pushed a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@mradcliffe @yanniboi
Issue LionsAd#38: Decouple download and installation of Drupal core a…
c2b060a 
…nd modules.
yanniboi pushed a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@mradcliffe @yanniboi
Issue LionsAd#38: Add missing change directory for phpunit-core runner
cfe551b
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
0bbef54 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
93584c0 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
ccc705a 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
3e4beb2 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
19e9c3d 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
54a10c1 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
db1b55d 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
72349d9 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
88f23db 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
ea1f601 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
748854b 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
74bf959 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
3ac43fb 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Revert phpunit-core runner to require installed Dru…
f6806e3 
…pal again.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Restructured drupal_ti_ensure_drupal and sub functi…
7c6f191 
…ons for backward compatibility.
yanniboi added a commit to yanniboi/drupal_ti that referenced this issue Jan 23, 2017
@yanniboi
Issue LionsAd#38: Revert phpunit-core runner to require installed Dru…
2fd9c16 
…pal again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@mradcliffe @LionsAd