This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Refactor block and transaction to remove duplicate signing block/transaction #55

Open

shuse2 opened this issue Feb 12, 2023 · 0 comments

Labels

type: refactoring

Collaborator

shuse2 commented Feb 12, 2023 •

edited

Loading

Description

Remove duplication of SigningTransaction and signingBlockHeader and use embedded struct.
Remove frozen transaction because defining interface for transaction in the package adds complexity without much benefit. interface should be defined in the user side.

Acceptance Criteria

All test should be passing

Additional Information

this requires Allow codec to use embedded struct #54 otherwise it will increase the non generated boilerplate code for codec

The text was updated successfully, but these errors were encountered:

shuse2 added the type: refactoring label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.