Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable the counter #2

Open
Loirooriol opened this issue Jun 26, 2018 · 6 comments
Open

Allow to disable the counter #2

Loirooriol opened this issue Jun 26, 2018 · 6 comments
Labels
enhancement New feature or request

Comments

@Loirooriol
Copy link
Owner

It seems some people are fine with clicking the browserAction when they want to see the number of tabs, and don't need the counter to be always present: DaAwesomeP/tab-counter#12

Tab Counter Plus does not continuously query tabs and then there is almost no performance hit to be avoided, but I can consider adding this option.

@Loirooriol Loirooriol added the enhancement New feature or request label Jun 26, 2018
@StoopidoMan
Copy link

I think that would Great

@ScienceDiscoverer
Copy link

I have another suggestion concerning this. It would be nice to make some setting to hide the counter compleately while window has less than X amount of tabs, and then re-enable it when there is more than X tabs.

For now, I managed to implement this via userChrome.css to enable the counter only when tabs overflow, like this:

#tabbrowser-tabs:not([overflow]) ~ #tab-counter-plus_loirooriol-browser-action {
	display: none !important;
}

#tabbrowser-tabs[overflow] ~ #tab-counter-plus_loirooriol-browser-action {
	display: -moz-box !important;
}

I placed my counter on the title-bar, instead of address bar, too. I also removed right spacer via CSS, so now tab counter acts as a useful spacer when tabs overflow!

But having build-in, customisable solution for specific number of tabs would be nice too!

@Loirooriol
Copy link
Owner Author

There is no API to completely hide a browser action. I can disable it, or show a plain image instead of a counter, but not hide it.

Hiding page actions was possible but I think they changed it, since in V3 there is just "action".

@Gitoffthelawn
Copy link

BTW, you can inject some CSS to hide the counter except on hover. I do this to keep the UI clean but powerful.

@Loirooriol
Copy link
Owner Author

Users can do that with userChrome.css. My add-on can't do it because WebExtensions are heavily restricted.

@Gitoffthelawn
Copy link

Gitoffthelawn commented Jun 17, 2022

Right, sorry, I should have mentioned users performing the injection via userChrome.css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants