Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unacknowledged command handling fixes and PodCommsSession improvements #136

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Unacknowledged command handling fixes and PodCommsSession improvements #136

wants to merge 1 commit into from

Conversation

itsmojo
Copy link

@itsmojo itsmojo commented Nov 18, 2024

  • Don't append an optional beep block to a getStatus with a pending unacknowledged command
  • Handle unacknowledged commands cases in acknowledgeAlerts(), beepConfig() & configureAlert()
  • Use checkCommandAgainstStatus() for seq # mismatch to determine insulin delivery status
  • Remove unneeded @discardResult attribute on various PodCommsSessions functions
  • Comment improvements and better source code synchronization between OmniKit and OmniBLE

@itsmojo
Unacknowledged command handling fixes and PodCommsSession improvements
b167114 
+ Don't append an optional beep block to a getStatus with a pending unacknowledged command
+ Handle unacknowledged commands cases in acknowledgeAlerts(), beepConfig() & configureAlert()
+ Use checkCommandAgainstStatus() for seq # mismatch to determine insulin delivery status
+ Remove unneeded @discardResult attribute on various PodCommsSessions functions
+ Comment improvements and better source code synchronization between OmniKit and OmniBLE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@itsmojo