Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit access #1

Open
MikePall opened this issue Jan 31, 2016 · 16 comments
Open

Commit access #1

MikePall opened this issue Jan 31, 2016 · 16 comments

Comments

@MikePall
Copy link
Member

Anyone who wants to help with the cleanup effort and feels qualified, please apply here for commit access to this repo.

Note: this does not automatically grant you commit access to the LuaJIT main repo, which is a tad more sensitive.

@Wiladams
Copy link
Collaborator

Wiladams commented Feb 1, 2016

I'd like to be granted commit access to this repo

@MikePall
Copy link
Member Author

MikePall commented Feb 1, 2016

Done.

@ladc
Copy link
Collaborator

ladc commented Feb 1, 2016

I would also like to contribute.

@MikePall
Copy link
Member Author

MikePall commented Feb 1, 2016

Done.

@fsfod
Copy link
Collaborator

fsfod commented Feb 1, 2016

Since you added me are you ok with the syntax that telescope's uses for tests that you can see in my fork fsfod@4a98d60. Telescope uses the same style as busted but is single file with no dependencies except for a separate pure lua command line runner.

@MikePall
Copy link
Member Author

MikePall commented Feb 1, 2016

I don't mind the syntax (better than busted). Converting everything to that style is straightforward, but maybe a bit premature.

IMHO the other organizational items from the README should be discussed first. Maybe open issues for them? But not 1:1, I wrote the list in a hurry. Sorry.

I guess a consistent naming scheme should be the first thing that needs to be agreed upon. Forget about the current test naming and grouping, though (that mess is entirely my fault).

After that, the tests could be split up, converted to the test support library style and commit-moved to a separate directory hierarchy under their new names.

Then one needs to comb through them and check whether they actually test what they are supposed to test. Some are quite old and the JIT compiler advanced enough in the meantime to turn them into empty loops. But don't forget that the interpreter needs to be exercised, too.

I have some quick input on non-x86/x64 testing:

Don't bother with native builds. Always perform cross-builds from an x86/x64 box, use QEMU user-mode (./configure --disable-kvm --disable-system --disable-user --enable-linux-user --target-list=ppc-linux-user,arm-linux-user,aarch64-linux-user,mips-linux-user,mipsel-linux-user) and run tests against a sysroot (qemu-arm -cpu cortex-a9 -L /opt/armhf/sysroot etc.). This simplifies testing (the tests have full local file system access) and massively cuts down on testing time compared to QEMU full-system emulation. GDB for QEMU user-mode is much more convenient, too.

Sorry, but I'm running out of time right now. I really wouldn't mind if you organize this yourselves. I've given @Wiladams, @ladc and @fsfod admin level access to this repo, so you can add more collaborators. Thank you!

@Wiladams
Copy link
Collaborator

Wiladams commented Feb 2, 2016

I half expect to see a "John Galt" business card get left behind...

But honestly, thanks for setting this up. It will be a good proof point of how action oriented this community is.

@agentzh
Copy link
Collaborator

agentzh commented Feb 4, 2016

Please add me as well :)

@ladc
Copy link
Collaborator

ladc commented Feb 4, 2016

Done :-)

@agentzh
Copy link
Collaborator

agentzh commented Feb 4, 2016

@ladc Thanks!

@NukeRusich
Copy link

I'd like to contribute. It looks like no one's done a thing since the initial commit.

@Wiladams
Copy link
Collaborator

I did one thing as a test, it was backed out.

Rules of engagement:
Even if you have direct access, do your work in a branch, or otherwise, and do pull requests.

The wiki outlines some naming conventions.

A test framework has been proposed, but no actual work has been submitted.

My suggestion would be to go ahead and do some prs.

Sent from my Windows Phone


From: Mark Rusichmailto:[email protected]
Sent: ‎2/‎20/‎2016 8:44 AM
To: LuaJIT/LuaJIT-test-cleanupmailto:[email protected]
Cc: William Adamsmailto:[email protected]
Subject: Re: [LuaJIT-test-cleanup] Commit access (#1)

I'd like to contribute. It looks like no one's done a thing since the initial commit.


Reply to this email directly or view it on GitHub:
#1 (comment)

@corsix
Copy link
Collaborator

corsix commented Apr 4, 2016

Requesting write access.

@MikePall
Copy link
Member Author

MikePall commented Apr 4, 2016

Done.

@dibyendumajumdar
Copy link
Contributor

@MikePall
I would like to help by adding the standard Lua 5.1 test suite (http://www.lua.org/tests/lua5.1-tests.tar.gz) - and possibly bits from later versions too. I do not know if these tests are already used but they don't appear to be. I have a lack of spare time so it will be a slow process, but it will give me great pleasure to help in this effort. If okay please grant me write access.

@ladc
Copy link
Collaborator

ladc commented Oct 8, 2016

@dibyendumajumdar done. Make sure to check for any license /IP issues though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants