Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summermode and bypass not working? #6

Open
RvRijsselt opened this issue May 19, 2022 · 2 comments
Open

Summermode and bypass not working? #6

RvRijsselt opened this issue May 19, 2022 · 2 comments

Comments

@RvRijsselt
Copy link

Are they working for you?

In my setup (different microcontroller, Particle Photon) the summer mode has always been 'no' and bypass '0'. I had to lower the data indices by 1 to get correct values.

    int ByPass = (int)data[7-1];
    int PreHeating = (int)data[8-1];
    int ByPassMotorCurrent = (int)data[9-1];
    int PreHeatingMotorCurrent = (int)data[10-1];
...
    int ByPassFactor  = (int)data[9-1];
    int ByPassStep  = (int)data[10-1];
    int ByPassCorrection  = (int)data[11-1];
...
    if ((int)data[13-1] == 1) {
@CommanderTux
Copy link

CommanderTux commented Jul 13, 2022

@RvRijsselt I can confirm your findings. Last week I discovered the same values as you did. Summer was always 'no'. Below the changes I've made. Now everything is working as expected.

    int ByPass = (int)data[6];
    int PreHeating = (int)data[7];
    int ByPassMotorCurrent = (int)data[8];
    int PreHeatingMotorCurrent = (int)data[9];
    int ByPassFactor  = (int)data[8];
    int ByPassStep  = (int)data[9];
    int ByPassCorrection  = (int)data[10];
    char* summerModeString;
    if ((int)data[12] == 1) {

@LukasdeBoer
Copy link
Owner

Nice! Could you create a PR? :) I'll gladly accept it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants