Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not delay to write vkCreateRayTracingPipelinesKHR block to capture file for deferred case. #1395

Open
locke-lunarg opened this issue Dec 18, 2023 · 0 comments
Labels
capture Issue with capture P1 Prevents an important capture from being replayed vulkan

Comments

@locke-lunarg
Copy link
Contributor

locke-lunarg commented Dec 18, 2023

#1192

This PR delays to write vkCreateRayTracingPipelinesKHR block to capture file for deferred case. The return pipeline of vkCreateRayTracingPipelinesKHR could be invalid because of deferred operation. The block is written when it's ready on VulkanCaptureManager::DeferredOperationPostProcess. However, we could still write the block at original moment even if the pipeline is invalid, and then add a MetaData to write pipelines when the pipelines are ready, if we want to keep the original capture.

@locke-lunarg locke-lunarg added the capture Issue with capture label Dec 18, 2023
@bradgrantham-lunarg bradgrantham-lunarg added the P1 Prevents an important capture from being replayed label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
capture Issue with capture P1 Prevents an important capture from being replayed vulkan
Projects
None yet
Development

No branches or pull requests

2 participants