Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VBA_orth checking for NaN values #64

Closed
NicolasClairis opened this issue Oct 8, 2018 · 2 comments
Closed

VBA_orth checking for NaN values #64

NicolasClairis opened this issue Oct 8, 2018 · 2 comments

Comments

@NicolasClairis
Copy link
Contributor

It would be good to add a line to check for NaN values in the VBA_orth function
Something like

if nonzeros( isnan(A) )
error('your matrix should not include any NaN value');
end

at the start of the script because otherwise any parasite NaN value will create a column full of NaN in the output possibly messing with other scripts afterwards.

lionel-rigoux added a commit that referenced this issue Apr 3, 2019
lionel-rigoux added a commit that referenced this issue Apr 3, 2019
* fail on weird values in VBA_orth
* simplifies nan suite
@lionel-rigoux
Copy link
Member

Fixed by 072682f

@NicolasClairis
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants