Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multinomial observation doesn't accept options.isYout #72

Closed
romainligneul opened this issue Mar 27, 2019 · 3 comments
Closed

Multinomial observation doesn't accept options.isYout #72

romainligneul opened this issue Mar 27, 2019 · 3 comments

Comments

@romainligneul
Copy link

Line 358 in VBA_updateDisplay generates an error whenever options.isYout contains non-zero values (for obvious reasons).
Commenting the line solves the problem.
lionel-rigoux added a commit that referenced this issue Mar 28, 2019
@lionel-rigoux
fix issue #72 when isYout is set for categorical
c058c97
@lionel-rigoux
Copy link
Member

Indeed, excluded points for categorical data are not taken into account properly in the display.
Commenting the line solves the issue but also remove the display of data points all together.

I included a more definitive fix in the branch I'm working on that solve a set of other performance issues in display functions. I will merge this branch onto the "development" one as soon as the tests are finished.

Thanks for the feedback!

@romainligneul
Copy link
Author

You're welcome! Thanks for this excellent tool.

lionel-rigoux added a commit that referenced this issue Mar 30, 2019
@lionel-rigoux
Optimisation of display (#73)
cdf5d7f 
* improves performances of display
* catch error on closing display during inversion
* fix issue #72 when isYout is set for categorical
@lionel-rigoux
Copy link
Member

This is now fixed in the development branch via cdf5d7f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lionel-rigoux @romainligneul