Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[very minor] AIC - BIC calculation #78

Closed
romainligneul opened this issue May 19, 2019 · 2 comments
Closed

[very minor] AIC - BIC calculation #78

romainligneul opened this issue May 19, 2019 · 2 comments

Comments

@romainligneul
Copy link

Hi Lionel,

The calculation of AIC and BIC values (at least when fitting multinomial data) does not adjust to the option updateX0, so that hidden states are still counted as free parameters even when they cannot be updated.

It is a very minor problem though as they can be recalculated post-hoc using LL.

Romain

@lionel-rigoux
Copy link
Member

Hi Romain,

Thanks for spotting this. I will have a look and see with Jean if this is an intended behavior or not.
In the meantime, setting SigmaX0 to zeros(dim.n) would effectively prevent any update of X0 and properly account for the degrees of freedom.

@lionel-rigoux
Copy link
Member

Hi Romain,

It seems that this is indeed the intended behaviour, as stated in the wiki.
Setting the prior variance to 0 is the only effective way to fix the parameters. The various "updatedXX" flags are only internal options to allow partial inference to speed up some iterations and should not be used to specify the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants