Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing gemmi-based mmcif reader (with easy extension to PDB/PDBx and mmJSON) #4712

Open
wants to merge 33 commits into
base: develop
Choose a base branch
from

add black instead of ruff

e80632c
Select commit
Loading
Failed to load commit list.
Open

Implementing gemmi-based mmcif reader (with easy extension to PDB/PDBx and mmJSON) #4712

add black instead of ruff
e80632c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 25, 2024 in 1s

93.59% (-0.06%) compared to 101008b

View this Pull Request on Codecov

93.59% (-0.06%) compared to 101008b

Details

Codecov Report

Attention: Patch coverage is 85.54217% with 12 lines in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (101008b) to head (e80632c).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
package/MDAnalysis/coordinates/MMCIF.py 75.75% 5 Missing and 3 partials ⚠️
package/MDAnalysis/topology/MMCIFParser.py 91.11% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4712      +/-   ##
===========================================
- Coverage    93.65%   93.59%   -0.06%     
===========================================
  Files          175      189      +14     
  Lines        21564    22715    +1151     
  Branches      3023     3028       +5     
===========================================
+ Hits         20195    21261    +1066     
- Misses         925     1005      +80     
- Partials       444      449       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.