Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] [JOSS] Consider using pytest groups #117

Open
HaoZeke opened this issue Aug 18, 2024 · 1 comment
Open

[FEATURE] [JOSS] Consider using pytest groups #117

HaoZeke opened this issue Aug 18, 2024 · 1 comment
Assignees

Comments

@HaoZeke
Copy link

HaoZeke commented Aug 18, 2024

Problem you'd like to address and suggestion
Related to the discussion in #100, perhaps the design would benefit from separating the tests into classes which require specific devices or not.

Additional context
Another "not necessarily actionable" point for JOSS, just one to keep in mind.

@mdmeeker mdmeeker self-assigned this Aug 22, 2024
@mdmeeker
Copy link
Collaborator

I'm leaning towards leaving the test suite as is since there are very few tests which require an available CUDA device. These are currently marked with skipif's which are conditional on the availability of a CUDA device via PyTorch and set to name the absence of a usable CUDA device as the reason for these being skipped in the pytest output.

I think this approach is more convenient overall for now, but I do agree that it will probably make more sense to introduce separate classes whenever the test suite is expanded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants