Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PaP] Another force closure bug when pattern isn't closed #22

Closed
ctrlcctrlv opened this issue Oct 14, 2021 · 1 comment
Closed

[PaP] Another force closure bug when pattern isn't closed #22

ctrlcctrlv opened this issue Oct 14, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@ctrlcctrlv
Copy link

Although I'm sure it annoys the developers ( :) ), this is a valid pattern:

line.glif

<?xml version="1.0" encoding="UTF-8"?>
<glyph name="line" format="2">
  <advance width="104"/>
  <outline>
    <contour>
      <point x="0" y="13" type="move" name="T"/>
      <point x="54" y="13" type="line"/>
    </contour>
  </outline>
</glyph>

But trying to use it is force closing once again. I think the recent PaP upgrades broke this.

$ MFEKstroke PAP --pattern patterns.ufo/glyphs/line.glif --path FRBAmericanCursive-SOURCE.ufo/glyphs/i.glif --out /tmp/i.glif -s 4

image

<?xml version="1.0" encoding="UTF-8"?>
<glyph name="i" format="2">
  <advance width="441"/>
  <unicode hex="0069"/>
  <outline>
    <contour>
      <point x="400" y="414" type="curve" smooth="yes"/>
      <point x="400" y="424"/>
      <point x="408" y="432"/>
      <point x="418" y="432" type="curve" smooth="yes"/>
      <point x="428" y="432"/>
      <point x="436" y="424"/>
      <point x="436" y="414" type="curve" smooth="yes"/>
      <point x="436" y="404"/>
      <point x="428" y="396"/>
      <point x="418" y="396" type="curve" smooth="yes"/>
      <point x="408" y="396"/>
      <point x="400" y="404"/>
    </contour>
    <contour>
      <point x="0" y="0" type="move" smooth="yes"/>
      <point x="42.171" y="22.3844"/>
      <point x="223.994" y="112.874"/>
      <point x="325" y="255" type="curve"/>
      <point x="299.121" y="206.164"/>
      <point x="218.201" y="82"/>
      <point x="218.201" y="32.8374" type="curve" smooth="yes"/>
      <point x="218.201" y="18.0871"/>
      <point x="232.85" y="-7.76738"/>
      <point x="271.342" y="-7.76738" type="curve" smooth="yes"/>
      <point x="307.241" y="-7.76738"/>
      <point x="362.329" y="21.9137"/>
      <point x="441" y="77" type="curve"/>
    </contour>
  </outline>
</glyph>
@ctrlcctrlv ctrlcctrlv added the bug Something isn't working label Oct 14, 2021
@ctrlcctrlv
Copy link
Author

Confirmed solved by MFEK/glifparser.rlib@927a06f, thanks @MatthewBlanchard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant