Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHub / GC - Add the GC stoic baseline model #40

Merged
merged 17 commits into from
Mar 28, 2024

Conversation

silvandeleemput
Copy link
Contributor

@silvandeleemput silvandeleemput commented Aug 2, 2023

This PR adds the GC STOIC baseline model (from the STOIC2021 challenge) to MHub.
GitHub Repo: https://github.com/luukboulogne/stoic2021-baseline
GC page: https://grand-challenge.org/algorithms/stoic2021-baseline/

Algorithm I/O

  • Input should be a CT Lung image (MHA) (This MHub implementation expects a Dicom which is converted to MHA using MhaConverter)
  • Outputs are:
    • A JSON file with the following output scores:
      *probability-covid-19
      *probability-severe-covid-19
  • Test images for this algorithm can be downloaded from here: https://stoic2021.grand-challenge.org/stoic-db/

Caveats

  • The PR target is main, but should be something like m-gc-stoic-baseline
  • In the Dockerfile the MHub model repo integration is currently marked TODO since it requires the creation of the appropriate branch for this code first.
  • Added a TODO to the MHAConverter since it doesn't have the panimg backend yet.

@LennyN95
Copy link
Member

I suggest we use ValueOutput in combination with a ReportExporter.

@LennyN95 LennyN95 self-assigned this Aug 13, 2023
@silvandeleemput
Copy link
Contributor Author

I suggest we use ValueOutput in combination with a ReportExporter.

I'll add these soon.

@silvandeleemput
Copy link
Contributor Author

The ValueOutputs and ReportExporter have been added, plus some minor cleanup.

@silvandeleemput
Copy link
Contributor Author

The repository commit has been fixed and additional comments have been added to the runner.

@silvandeleemput
Copy link
Contributor Author

I removed the ValueOutput.Meta lines and updated the Dockerfile with the new import

models/gc_stoic_baseline/meta.json Outdated Show resolved Hide resolved
models/gc_stoic_baseline/meta.json Outdated Show resolved Hide resolved
models/gc_stoic_baseline/meta.json Show resolved Hide resolved
@silvandeleemput
Copy link
Contributor Author

output.zip

@silvandeleemput
Copy link
Contributor Author

silvandeleemput commented Mar 19, 2024

/test

sample:
  idc_version: 17.0
  data:
    - SeriesInstanceUID: 1.3.6.1.4.1.14519.5.2.1.6279.6001.141365756818074696859567662357
      aws_url: s3://idc-open-data/6079cc3b-4b0f-41ec-bdbb-c6e754e88229/*
      path: dicom

reference:
  url: https://github.com/MHubAI/models/files/14650741/output.zip

Test Results (24.03.28_17.30.31_kb1YE6N1mX)
id: c50ad4de-ce35-4a60-a22e-85029c1ed031
date: '2024-03-28 18:03:49'
checked_files:
- file: gc_stoic_baseline_covid_scores.json
  path: /app/test/src/1.3.6.1.4.1.14519.5.2.1.6279.6001.141365756818074696859567662357/gc_stoic_baseline_covid_scores.json
  checks:
  - checker: DataFileCheck
    findings:
    - label: Value similar
      description: Value of key 'probability-covid-19' is similar in source file
      subpath: probability-covid-19
      info:
        scale: 1
        precision: 5
        src: 0.5520431399345398
        ref: 0.5520455241203308
    - label: Value similar
      description: Value of key 'probability-severe-covid-19' is similar in source
        file
      subpath: probability-severe-covid-19
      info:
        scale: 1
        precision: 4
        src: 0.5822800993919373
        ref: 0.5822792053222656
  - checker: SizeCheck
summary:
  files_missing: 0
  files_extra: 0
  checks:
    DataFileCheck:
      files: 1
      findings:
        Value similar: 2
    SizeCheck:
      files: 1
conclusion: false

@silvandeleemput
Copy link
Contributor Author

/review

The meta.json file has been updated and the comments have been addressed.

@github-actions github-actions bot added the REQUEST REVIEW Attach this label to your PR when your submission is "in progress" and is ready to be reviewed by us label Mar 19, 2024
@LennyN95 LennyN95 removed REQUEST REVIEW Attach this label to your PR when your submission is "in progress" and is ready to be reviewed by us TEST REQUESTED labels Mar 28, 2024
@LennyN95 LennyN95 merged commit 8ae2186 into MHubAI:main Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants