Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update for dseg/rtstruct [WIP] #99

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

surajpaib
Copy link
Contributor

@surajpaib surajpaib commented Sep 11, 2024

@LennyN95 PR'ing early for feedback

@LennyN95
Copy link
Member

Looks good; ultimatively, we'd ditch the json file and use the value outputs. I've a branch with preparations for sth. like @IO.Data.Input, but I feel at the current point this would be an extra overhead not meeting the derived benefit. However, it'd be great to revisit this later.

@surajpaib
Copy link
Contributor Author

@LennyN95 This would be cool to do in the long run!

For now, I will make updates for rest of the workflows and complete the PR with latest test updates

@surajpaib surajpaib marked this pull request as ready for review September 27, 2024 23:38
@surajpaib
Copy link
Contributor Author

@LennyN95 Will update the tests on zenodo as well

@surajpaib
Copy link
Contributor Author

@LennyN95 Added files for all workflows! I think it's good to merge from my end. Supports a wide range of tested workflows now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Submitted Implementations
Development

Successfully merging this pull request may close these issues.

2 participants