-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Urgent update of configuration to fulfil MIAPPE 1.1 recommendations #4
Comments
Take a look at the branch for v1.1 in this repository. |
Thank you for update. Sorry, I did not see the new branch. The last time I checked the repository there was no 1.1 configuration... Nevertheless I have a question: |
@PapoutsoglouE +1, it is still on my TODO to modify the MIAPPE ISA configurations to reflect the point of discussion we had. @arendd: it seems you describe a situation where an ISA ParameterValue[] could be defined and point to an external data file holding those measurements.
|
Thank you Eliana, Philippe for your effort.
|
@arendd, thank you for bringing this to our attention! @proccaserra, I don't think the proposed solution would work smoothly with MIAPPE v1.1's view of environmental measurements. Just like plant trait observations, measurements referring to environmental attributes should be treated as data: presented in a data file that the assays point to. They should also, similarly, be attached to an observation unit. The environmental attributes themselves should be listed as observation variables, and included in the trait definition file. For example, if you have a temperature sensor per plot, and plot is one of your observation units, attaching additional observations to it (environmental or phenotypic) is simple. But if you have a case where measurements from a single sensor, at one specific location in the field, are treated as representative of the whole field/greenhouse compartment, it might be more complicated. After discussing with @DanFaria, we came up with the idea of allowing a special source node in the Study file, indicating that the biological material in the observation unit is all the biological material in that specific study. The term itself could be something like "all" or "study". I realise this is a bit abstract, so I hope the following picture clears it up: Does this make sense to you? |
That's an important point.
For the example from @PapoutsoglouE , the orange part is fine with me and in fact seems to solve a provenance problem that's bugging me. I am not confortable with the green part. |
We need an update on the ISATab configuration to fulfil the latest version of the MIAPPE recommendation in version 1.1.
The text was updated successfully, but these errors were encountered: