Disabling login breaks sending emails

[gravesm]

Turning off login for the app, which is the default state, breaks sending emails:

solenoid/solenoid/settings/base.py

Lines 274 to 278 in f4781fe

	if os.environ.get('DJANGO_LOGIN_REQUIRED') == 'True':
	# You can't actually set a Boolean environment variable, just a string.
	LOGIN_REQUIRED = True
	else:
	LOGIN_REQUIRED = False

Without auth, the anonymous user has no email attribute:

solenoid/solenoid/emails/views.py

Line 129 in f4781fe

email.send(self.request.user.email)

Given that sending emails is the core functionality of the application, it doesn't seem useful to me for the app to really ever be run in a situation when emails aren't processed. Whether emails actually get sent or not should be handled by configuring the emailing backend.

The proper solution is probably just to always have auth enabled. In general, there are way too many switches for running this application in dev vs prod. The more we can do to make the app run the same everywhere and just be configured by env vars the better.