Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timeout on Elements requests #98

Open
gravesm opened this issue Jun 22, 2018 · 0 comments
Open

Use timeout on Elements requests #98

gravesm opened this issue Jun 22, 2018 · 0 comments

Comments

@gravesm
Copy link

gravesm commented Jun 22, 2018

This statement will never be True: https://github.com/MITLibraries/solenoid/blob/master/solenoid/elements/views.py#L60 since requests will always return a response, raise an exception or hang indefinitely if no timeout has been provided to the request. The best thing to do will probably be to set a timeout on the request and catch any requests.Timeout exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant