Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert screen crashes on load on Android in RNTester app #21

Open
anku255 opened this issue Jun 12, 2020 · 0 comments · May be fixed by #22
Open

Alert screen crashes on load on Android in RNTester app #21

anku255 opened this issue Jun 12, 2020 · 0 comments · May be fixed by #22

Comments

@anku255
Copy link
Member

anku255 commented Jun 12, 2020

Description

Alert screen crashes on load in Android in the RNTester app.

image

React Native version:

RN Tester builds directly from the source which is pointed to the master branch.

Steps To Reproduce

  1. Run RNTester App locally on an Android simulator or device.
  2. Search for Alert API
  3. Open the screen for Alert API

Expected Results

The Alert API screen should open and it should show all the alert examples.
anku255 added a commit that referenced this issue Jun 12, 2020
@anku255
Fix alert screen crash in android in RNTester app (#21)
f2409db
This was referenced Jun 12, 2020
Open
Closed
facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Jul 13, 2020
@anku255 @facebook-github-bot
Fix alert screen crash in android in RNTester app (#29150)
f898bb6 
Summary:
fixes - MLH-Fellowship#21

[Reviewed by jevakallio](MLH-Fellowship#22)

## Changelog

Before:

![image](https://user-images.githubusercontent.com/22813027/84471321-ba63bf00-aca2-11ea-92c0-3b43a8bdd28a.png)

After:

<img width="305" alt="Screenshot 2020-06-12 at 11 49 31 AM" src="https://user-images.githubusercontent.com/22813027/84471351-c8b1db00-aca2-11ea-9844-2b06da36e590.png">
Pull Request resolved: #29150

Test Plan:
1. Run the RNTester app locally on both android and iOS.
2. Open the Alert API screen.
3. Alert examples should be visible and functional in both android and iOS.

Screenshot for both android and iOS screens-

<img width="688" alt="Screenshot 2020-06-12 at 11 52 21 AM" src="https://user-images.githubusercontent.com/22813027/84471544-2d6d3580-aca3-11ea-9142-5f31a3daaf4e.png">

Reviewed By: cpojer

Differential Revision: D22067670

Pulled By: rickhanlonii

fbshipit-source-id: e7c43b77a30ae2e258303ce84f7fc4dee63776e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix alert screen crash in android in RNTester app (#21) MLH-Fellowship/react-native
1 participant
@anku255