Default Scheduler Starts at 2:00 and Ends at 1:00 Instead of 00:00 to 23:59 #541
Assignees
Labels
bug
Something isn't working
Comments
rania-is
changed the title
janoliver20
added a commit
that referenced
this issue
Dec 2, 2024
Switches from require to import statements for consistency and modern syntax in both JavaScript and Vue files. Introduces computed properties for minDate and maxDate to improve date handling and ensure accurate time settings for scheduled events. This enhances code readability and maintains better date boundaries within the scheduler component.
|
Default Schedulers now start at 00:00 on the first day and ends at 23:59 on the last day. |
|
Hi @andresgruber, When I add a new observation and no schedule is defined, it still starts at 1:00 AM instead of midnight (00:00) on the first day of the study and ends at 1:00 AM instead of 23:59 on the last day! |
janoliver20
added a commit
that referenced
this issue
Jan 22, 2025
Removed unused `dateIsValid` function from `dateUtils.ts` to streamline the utility file. Introduced helper functions `minDate` and `maxDate` in `ObservationDialog.vue` to standardize date manipulations. Additionally, reordered imports for better readability and made minor style adjustments.
|
Fixed in PR #574 |
janoliver20
added a commit
that referenced
this issue
Jan 22, 2025
#541: Refactor date handling and cleanup unused code.
|
Tested, the behavior is now the same as with #555. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When no schedule is defined for an observation, a default scheduler is automatically added for the entire study duration.
However, it starts at 2:00 AM instead of midnight (00:00) on the first day of the study and ends at 1:00 AM instead of 23:59 on the last day.
The text was updated successfully, but these errors were encountered: