Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsciiDoctor images don't preview correctly in GitHub #32

Open
johanjan opened this issue Sep 5, 2018 · 2 comments
Open

AsciiDoctor images don't preview correctly in GitHub #32

johanjan opened this issue Sep 5, 2018 · 2 comments
Assignees

Comments

@johanjan
Copy link
Contributor

johanjan commented Sep 5, 2018

The image path handling in AsciiDoctor clashes with GitHub preview. For example, the images render correctly in:

http://book.mso4sc.cemosis.fr/pilots/0.1/

But when edited in GitHub and previewed the images are broken:

https://github.com/mso4sc/book.mso4sc.eu/edit/master/docs/pilots/modules/ROOT/pages/index.adoc

@prudhomm prudhomm self-assigned this Sep 6, 2018
@prudhomm
Copy link
Collaborator

prudhomm commented Sep 6, 2018

There is a simple trick to do to have this support in asciidoc. asciidoc can recognize that it is woking withing github or not. that's how the magic is done. I can put an example if you like and then you reproduce

@johanjan
Copy link
Contributor Author

johanjan commented Sep 7, 2018

Thanks, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants