From a4af1f30f35b962c344ea3f6a23b0f9ba089459a Mon Sep 17 00:00:00 2001
From: ssorin <ssorin@dwdlc.com>
Date: Tue, 14 Jan 2025 14:24:13 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=91=94(dashboard)=20update=20consent=20ma?=
 =?UTF-8?q?nagement=20logic=20and=20improve=20UI=20accessibility?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Disabled updates to non-AWAITING consents and enhanced the bulk update logic to enforce the restriction.
Disabled checkbox if status is VALIDATED.
Added tooltips to consent labels in the UI for better context
Fix the home URL in the navigation menu.
---
 .../apps/consent/templates/consent/manage.html       |  8 ++++++--
 src/dashboard/apps/consent/tests/test_views.py       | 12 +++++++++++-
 src/dashboard/apps/consent/views.py                  |  7 +++++--
 src/dashboard/templates/blocks/main_menu.html        |  2 +-
 4 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/src/dashboard/apps/consent/templates/consent/manage.html b/src/dashboard/apps/consent/templates/consent/manage.html
index 029fa689..8d05ae86 100644
--- a/src/dashboard/apps/consent/templates/consent/manage.html
+++ b/src/dashboard/apps/consent/templates/consent/manage.html
@@ -43,11 +43,15 @@ <h2>{% trans "Manage consents" %}</h2>
                        name="status"
                        value="{{ consent.id }}"
                        id="{{ consent.id }}"
-                       {% if consent.status == 'VALIDATED' %} checked{% endif %}
+                       {% if consent.status == 'VALIDATED' %} checked="checked" disabled="disabled"{% endif %}
                        aria-describedby="{{ consent.id }}-messages"
                        data-fr-js-checkbox-input="true"
                        data-fr-js-checkbox-actionee="true" />
-                <label class="fr-label" for="{{ consent.id }}">{{ consent.delivery_point.provider_assigned_id }} </label>
+                <label class="fr-label" for="{{ consent.id }}"
+                       {% if consent.status == 'VALIDATED' %}title="{% trans "Delivery point is already validated" %}">{% endif %}
+                       {% if consent.status == 'AWAITING' %}title="{% trans "Delivery point awaiting consent" %}">{% endif %}
+                  {{ consent.delivery_point.provider_assigned_id }}
+                </label>
                 <div class="fr-messages-group" id="{{ consent.id }}-messages" aria-live="assertive"></div>
               </div>
             </div>
diff --git a/src/dashboard/apps/consent/tests/test_views.py b/src/dashboard/apps/consent/tests/test_views.py
index 41e1ca14..41dbe678 100644
--- a/src/dashboard/apps/consent/tests/test_views.py
+++ b/src/dashboard/apps/consent/tests/test_views.py
@@ -7,7 +7,7 @@
 from django.urls import reverse
 
 from apps.auth.factories import UserFactory
-from apps.consent import AWAITING, VALIDATED
+from apps.consent import AWAITING, REVOKED, VALIDATED
 from apps.consent.factories import ConsentFactory
 from apps.consent.models import Consent
 from apps.consent.views import ConsentFormView
@@ -62,6 +62,16 @@ def test_bulk_update_consent_status(rf):
     # and checks that the data has changed to VALIDATED after the update.
     assert all(c == VALIDATED for c in Consent.objects.values_list("status", flat=True))
 
+    # bulk update from VALIDATED to AWAITING: no data must be updated
+    assert view._bulk_update_consent(ids, AWAITING) == 0
+    # and checks that the status has not changed after the update.
+    assert all(c == VALIDATED for c in Consent.objects.values_list("status", flat=True))
+
+    # bulk update from VALIDATED to REVOKED: no data must be updated
+    assert view._bulk_update_consent(ids, REVOKED) == 0
+    # and checks that the status has not changed after the update.
+    assert all(c == VALIDATED for c in Consent.objects.values_list("status", flat=True))
+
 
 @pytest.mark.django_db
 def test_bulk_update_consent_status_with_fake_id(rf):
diff --git a/src/dashboard/apps/consent/views.py b/src/dashboard/apps/consent/views.py
index 94d64de6..cd8b8fec 100644
--- a/src/dashboard/apps/consent/views.py
+++ b/src/dashboard/apps/consent/views.py
@@ -84,9 +84,12 @@ def _get_entities(self) -> list:
             return list(user.get_entities())
 
     def _bulk_update_consent(self, ids: list[str], status: str) -> int:
-        """Bulk update of the consent status for a given status and list of entities."""
+        """Bulk update of the consent status for a given status and list of entities.
+
+        Only `AWAITING` consents can be updated by users.
+        """
         return (
-            Consent.objects.filter(id__in=ids)
+            Consent.objects.filter(id__in=ids, status=AWAITING)
             .filter(
                 Q(delivery_point__entity__users=self.request.user)
                 | Q(delivery_point__entity__proxies__users=self.request.user)
diff --git a/src/dashboard/templates/blocks/main_menu.html b/src/dashboard/templates/blocks/main_menu.html
index 30571c32..92c60eb2 100644
--- a/src/dashboard/templates/blocks/main_menu.html
+++ b/src/dashboard/templates/blocks/main_menu.html
@@ -18,7 +18,7 @@
       <ul class="fr-nav__list">
         {% if request.user.is_authenticated %}
           <li class="fr-nav__item">
-            {% url 'index' as home_url %}
+            {% url 'home:index' as home_url %}
             <a class="fr-nav__link"
                href="{{ home_url }}"
                target="_self"