Use docker/build-push-action to cache docker build #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alastair
force-pushed
the
change-docker-cache
branch
from
bc1ff44
to
88c7eff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we use docker buildx in the unit tests, use the
docker/build-push-actionto allow us to use docker's built-in layer cache when running tests.This also builds the base image manually instead of using
make, as the makefile now contains both the py2 and py3 base images and we only need the py3 one.I manually build the worker image (to cache it), and then run docker-compose build again to correctly tag it. Theoretically this should use existing layers and then tag the image as expected.
I use 2 "cache images" in the github docker cache. This should make the caching operation quite fast because it stays within github instead of going to docker hub.