Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DECOHack] "Safe" Freeing of States from a Starting Label #80

Open
MTrop opened this issue Jul 23, 2022 · 2 comments
Open

[DECOHack] "Safe" Freeing of States from a Starting Label #80

MTrop opened this issue Jul 23, 2022 · 2 comments
Labels
enhancement Nice-to-haves and things that can actually help current behavior. low priority Rarer issues with workarounds, or nice-to-haves that are not-so-important.

Comments

@MTrop
Copy link
Owner

MTrop commented Jul 23, 2022

So, DECOHack's state freeing is a tad... overzealous, let's say.

There needs to be a way to safely free a state on a weapon or thing such that it doesn't "overfree" what is expected, despite it being the intended behavior.

A new clause keyword may be in order. Something like:

weapon WP_PISTOL only free Label

Or somesuch language to convey that it should only free that state until it hits a state that has a defined label. Will a reverse lookup need to be in order?

This may turn into a bit of a complicated issue, unfortunately, as the traverser only can see the next state via indexes, not labels. A quick scan may need to be in order at startup to set these up, if not baked into code, initially.

@MTrop MTrop added the enhancement Nice-to-haves and things that can actually help current behavior. label Jul 23, 2022
@MTrop
Copy link
Owner Author

MTrop commented Jul 27, 2022

A small bandage for the reason for this enhancement was added in commit aa3016f.

This kinda puts this issue in low priority, because the solution appears to be a lot more complicated than I think it is.

@MTrop MTrop added the low priority Rarer issues with workarounds, or nice-to-haves that are not-so-important. label Jul 27, 2022
@MTrop
Copy link
Owner Author

MTrop commented Jan 31, 2025

I wonder if the addition of commit 0aabf7d makes this sort of thing moot? It warns the user of a state re-free, so this issue is in an even lower priority than before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Nice-to-haves and things that can actually help current behavior. low priority Rarer issues with workarounds, or nice-to-haves that are not-so-important.
Projects
None yet
Development

No branches or pull requests

1 participant