New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL task name issue #3

Open

biplobice opened this issue May 22, 2018 · 1 comment

Contributor

biplobice commented May 22, 2018

https://github.com/concrete5cojp/ansible-c5-ma/blob/master/prod-ansible-role/roles/mysql_server/tasks/main.yml#L17

This task name should be changed. With if condition either Restart mysqld (CentOS6) or Restart mysqld (CentOS7)

IMHO, it's better to name it as only Restart mysqld then apply the if inside the task. i.e.-

Name: Restart mysqld
if(centos_version = 6) {
    // Run command as 6
} else {
   // Run command as 7
}

The text was updated successfully, but these errors were encountered:

Contributor

katzueno commented May 22, 2018

Thx.
Would you send me a PR when you have a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment