Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make # Charge_Style a required keyword #150

Open
emarinri opened this issue Nov 30, 2023 · 0 comments
Open

Make # Charge_Style a required keyword #150

emarinri opened this issue Nov 30, 2023 · 0 comments

Comments

@emarinri
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Users have requested that the keyword # Charge_Style is required instead of optional. Currently, if this keyword is not found, the electrostatic style is set to none and thus no electrostatic interactions are required.

Describe the solution you'd like

Make it a required keyword or set ewald as a default. For the first option, the user must decide if electrostatic computation is relevant for the problem. An alternative solution is to make ewald as a default and always compute electrostatic interactions. It seems to me that both options are safe. The second would involve a higher computational for uncharged systems if the keyword is not specified.

Additional context

mosdef_cassandra uses ewald as a default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant