Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move_rotate.f90 unused variables? #92

Open
GarrettTow opened this issue Jan 11, 2021 · 1 comment
Open

move_rotate.f90 unused variables? #92

GarrettTow opened this issue Jan 11, 2021 · 1 comment

Comments

@GarrettTow
Copy link

In 'move_rotate.f90', the subroutine called 'Rotate_Molecule_Axis' (starting on line 362) allocates and computes one-dimensional arrays called 'dxrot', 'dyrot', and 'dzrot'. These arrays don't seem to be used for anything internal to the 'Rotate_Molecule_Axis' subroutine and are output to the 'dx', 'dy', and 'dz' arguments specified when the 'Rotate_Molecule_Axis' subroutine is called. The 'dx', 'dy', and 'dz' arrays are local to the 'Rotate' subroutine and don't appear to be utilized anywhere. Am I overlooking where these quantities are utilized in some fashion or are these arrays vestiges of earlier versions that can now be removed?

@rwsmith7531
Copy link
Contributor

I know you opened this years ago, but I'll give an answer anyway. There are many unused variables and there's a lot of dead code in Cassandra, unfortunately. Unused variables tend to be removed by the compiler during optimization, so unused variables probably don't impact performance, although they do sometimes make it more difficult to understand the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants