Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module] video-to-bootanimation #254

Closed
rhythmcache opened this issue Nov 22, 2024 · 3 comments
Closed

[Module] video-to-bootanimation #254

rhythmcache opened this issue Nov 22, 2024 · 3 comments
Assignees
Labels
approved Modules that have been approved module A module submission

Comments

@rhythmcache
Copy link

rhythmcache commented Nov 22, 2024

ID

video-to-bootanimation

Name

Video To Bootanimation

Description

set Videos as Bootanimation

Module repository link

https://github.com/rhythmcache/video-to-bootanimation/

Source code link (for compiled binaries/APKs)

  1. /bin/zip - https://github.com/termux/termux-packages/tree/master/packages/zip https://packages.termux.dev/apt/termux-main/pool/main/z/zip/

  2. /bin/ffmpeg - https://github.com/Khang-NT/ffmpeg-binary-android

Anti-Features

No response

@rhythmcache rhythmcache added the module A module submission label Nov 22, 2024
@DerGoogler
Copy link
Member

Please provide the sources of the following binaries:

Remove comments: https://github.com/rhythmcache/video-to-bootanimation/blob/main/module.prop#L7

What is that? 👉 https://github.com/rhythmcache/video-to-bootanimation/blob/main/customize.sh#L167
Just put index.html into the webroot folder...

Remove the index.html. Be serious developer.

Caution

I'm periodically checking module of their quality if something like this appears I'm immediately remove the access for ALL maintainers.

@DerGoogler DerGoogler added the please fix Fix something for approval label Nov 22, 2024
@DerGoogler DerGoogler self-assigned this Nov 22, 2024
@rhythmcache
Copy link
Author

  1. Sources of binaries:

  2. Webroot and index.html:

    • I’ve removed the webroot and index.html
  3. Comments in module.prop:

    • removed the comments from module.prop

@DerGoogler DerGoogler added approved Modules that have been approved and removed please fix Fix something for approval labels Nov 22, 2024
Copy link

Hey @rhythmcache,

your module submission has been approved!
The module will likely be available at https://github.com/Magisk-Modules-Alt-Repo/video-to-bootanimation.

Check your e-mail inbox for an invite to your new repository and remember to 'Watch' your repository on Github to have new issues in it show up in your feed.

Make sure to change your local repository's push URLs or configure 2 parallel push URLs.

Best regards,
The MMAR Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Modules that have been approved module A module submission
Projects
None yet
Development

No branches or pull requests

2 participants