Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module] wadbd #255

Closed
rhythmcache opened this issue Nov 22, 2024 · 6 comments
Closed

[Module] wadbd #255

rhythmcache opened this issue Nov 22, 2024 · 6 comments
Assignees
Labels
approved Modules that have been approved module A module submission

Comments

@rhythmcache
Copy link

ID

wadbd

Name

WirelessADBD-Controller

Description

A simple Magisk module to control the Wireless ADB daemon

Module repository link

https://github.com/rhythmcache/wireless-adb-controller

Source code link (for compiled binaries/APKs)

No response

Anti-Features

No response

@rhythmcache rhythmcache added the module A module submission label Nov 22, 2024
@DerGoogler DerGoogler changed the title [Module] WirelessADBD-Controller [Module] wadbd Nov 22, 2024
@DerGoogler
Copy link
Member

Why is the wadbd bin inside the install script? Please put the wadbd bin into /system/bin.

@DerGoogler DerGoogler added the please fix Fix something for approval label Nov 22, 2024
@DerGoogler DerGoogler self-assigned this Nov 22, 2024
@HuskyDG
Copy link
Member

HuskyDG commented Nov 22, 2024

Magisk 28.0+ app will ignore META-INF, so your module might fail to install

@DerGoogler
Copy link
Member

Magisk 28.0+ app will ignore META-INF, so your module might fail to install

Since when that? This is new.

@DerGoogler
Copy link
Member

But ignoring does not mean failing??

@rhythmcache
Copy link
Author

Why is the wadbd bin inside the install script? Please put the wadbd bin into /system/bin.

Fixed.

@DerGoogler DerGoogler added approved Modules that have been approved and removed please fix Fix something for approval labels Nov 22, 2024
Copy link

Hey @rhythmcache,

your module submission has been approved!
The module will likely be available at https://github.com/Magisk-Modules-Alt-Repo/wadbd.

Check your e-mail inbox for an invite to your new repository and remember to 'Watch' your repository on Github to have new issues in it show up in your feed.

Make sure to change your local repository's push URLs or configure 2 parallel push URLs.

Best regards,
The MMAR Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Modules that have been approved module A module submission
Projects
None yet
Development

No branches or pull requests

3 participants