Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested requirements.txt logic is not fully complete #17

Open
1 task done
Jped opened this issue Jul 1, 2022 · 0 comments
Open
1 task done

Nested requirements.txt logic is not fully complete #17

Jped opened this issue Jul 1, 2022 · 0 comments

Comments

@Jped
Copy link
Contributor

Jped commented Jul 1, 2022

Describe the bug

We should be looking for a requirements.txt in the folder of the task, if it does not exist there we go up one parent directory until the root tasks directory.

What is currently happening is that it looks for a requirements.txt in the current directory and then if it cant find it looks for one in the root ./tasks directory.

It also makes the requirements.txt in the root directory a requirement which it doesn't necessarily have to be.

Is there an existing issue for this?

  • I have searched the existing issues

Reproduction

You can create a tasks structure like this:

tasks
|__dir1
     |-requirements.txt
     |_dir2
        |_tasks.py

It will raise an error bc there is no root requirements.txt which it shouldn't, and then if you add a root req file it will use that for the tasks in tasks.py when it should be using ./tasks/dir1/requirements.txt

Screenshot

No response

Logs

None

System Info

Current

Severity

serious, but I can work around it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant