Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotations in 3D #111

Open
hdavid16 opened this issue Feb 6, 2023 · 3 comments
Open

Rotations in 3D #111

hdavid16 opened this issue Feb 6, 2023 · 3 comments

Comments

@hdavid16
Copy link
Collaborator

hdavid16 commented Feb 6, 2023

Current implementation uses tangent angles and Billboard for rotations.
I noticed the comment in to_angle: For some perspectives this might give wrong angles in 3d

Is this because we are using Billboard, which takes an angle? Should be we using Quaternions for 3D space?

@hdavid16
Copy link
Collaborator Author

hdavid16 commented Feb 6, 2023

Actually, 3D rotations do work in with Billboard. So I guess no need to do this....?

@hdavid16 hdavid16 closed this as completed Feb 6, 2023
@hdavid16 hdavid16 reopened this Feb 6, 2023
@hexaeder
Copy link
Collaborator

hexaeder commented Feb 6, 2023

I think the problem is that we need to figure out the point t where the arrow is close to the node marker in projected pixel space rather than data space. In 2d no problem because its just a linear mapping from data to pixel space. In 3d its more complicated. I think quaternions would be neede in case of 3d arrow 'cones' rather than flat sprites like the makie arrows plot do.

@hdavid16
Copy link
Collaborator Author

hdavid16 commented Feb 7, 2023

Ahhh yes. Makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants