Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register package #10

Closed
lazarusA opened this issue Mar 19, 2024 · 5 comments
Closed

register package #10

lazarusA opened this issue Mar 19, 2024 · 5 comments

Comments

@lazarusA
Copy link

I had been using this package lately. No problems so far. Maybe registering it would be nice 😄.

@asinghvi17
Copy link
Member

We could! @TheCedarPrince is this ready for your use?

@TheCedarPrince
Copy link
Collaborator

Yea! I have actually already been using it @asinghvi17. The outstanding question I have is if we are planning to upstream it to Makie at some point, does it make sense to release it as its own standalone package? Or what else is left before upstreaming?

Also, cool to hear that you've been using it @lazarusA ! 😄

I'd be fine with releasing it, but just wondering if we should target upstreaming first instead of release. Thoughts Anshul?

@asinghvi17
Copy link
Member

Since this is a bit complex (and I have been considering a kind of force-directed algorithm which would give pretty optimal packing), I think we should keep it a separate package for now. We can always avoid breakage after upstreaming by simply re-exporting the relevant Makie symbols.

Plus, if anyone finds a bug in the algorithms, it's easier to patch and release now than it would be if it's in base Makie as well.

@TheCedarPrince
Copy link
Collaborator

That makes a lot of sense! Alright, then let's release it. 😃

P.S. What is the algorithm you are mentioning? Does it come from a paper somewhere? Just curious.

@asinghvi17
Copy link
Member

asinghvi17 commented Mar 19, 2024

No, it's a pretty simple idea (but a bit wasteful computationally). It would basically be each marker repelling the others and itself moving in the y-direction, while simultaneously being attracted to its original data value, to try and create optimal packing. I'm sure it's not the most efficient but it would be a fun experiment :D.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants