display needs to be removed from Tyler to support WGLMakie

[alex-s-gardner]

Conversation from Slack

Tabea
How can you send it via JSServe? I can show the figure, but then it doesn't load further tiles

Simon Danisch
Ah, I suspect you may not have a websocket connection, leading to no interactivity... Can you zoom into a normal scatter(1:4) plot?

Tabea
Yes, I can also zoom into the Tyler map if using App(tyler.figure)

Simon Danisch
Oh.. that sounds like a bug then

Tabea
Well I think Tyler needs the screen to be open. I don't know if that's the case, if I am only showing the figure?

Simon Danisch
Ah there was an issue like that

Simon Danisch
I think we need to remove the display call in Tyler ^^

Tabea
How can we then check whether the Tyler map is open?

Simon Danisch
Good question.... I honestly don't know how this is even working with a display call inside app.. I will need to take a look at it
😅

Simon Danisch
But I suspect this needs a fix in Tyler

Simon Danisch
You could try to remove the display call and remove the isopen(screen) with some other condition... Maybe just true for a quick test

Tabea
That's not so trivial 😅 Screen is all over the place...

Tabea
I will give it a try

Simon Danisch
Ok, feel free to ask me if anything doesn't work 😉 Otherwise, I can take a look later today

Tabea
Ok, so it seems to work 😊 leaving the display.... but replacing isopen(screen) with true, then showing it via App(tyler.figure). But this can only be a hack😂

Simon Danisch
Sure... Lets see if we can find a better solution soon!

Anshul Singhvi
Why exactly does Tyler need the screen? It can always call update_state_before_display!(ax) on its axis, if that's what is needed

Simon Danisch
That's not what it's needed for

Simon Danisch
It doesn't really need screen, it was just easier for a first implementation

[alex-s-gardner]

@SimonDanisch looking at Tyler I see that screen from display(figure; title="Tyler (with Makie)") is fairly heavily embedded into the code. What are you're thoughts on refactoring. If I had a clearer sense of what needs changing I'd be happy to take a crack at it.

[asinghvi17]

fixed in #69