Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract WimParser to a dedicated gem #514

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Feb 3, 2021

@Fryguy Fryguy force-pushed the extract_wim_parser branch from 634d941 to ac7d017 Compare February 3, 2021 17:47
@Fryguy Fryguy mentioned this pull request Feb 3, 2021
50 tasks
@miq-bot
Copy link
Member

miq-bot commented Feb 3, 2021

Checked commit Fryguy@ac7d017 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@Fryguy
Copy link
Member Author

Fryguy commented Feb 3, 2021

@miq-bot cross-repo-test manageiq, manageiq-ui-classic, manageiq-api

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Feb 3, 2021
Copy link
Member

@chessbyte chessbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-repo tests are red (but seems unrelated). Otherwise, LGTM

@Fryguy
Copy link
Member Author

Fryguy commented Feb 8, 2021

Cross repo is green now

@chessbyte chessbyte merged commit bed9385 into ManageIQ:master Feb 8, 2021
@Fryguy Fryguy deleted the extract_wim_parser branch February 10, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants