Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move miq_tempfile here #124

Merged
merged 1 commit into from
May 8, 2020
Merged

Move miq_tempfile here #124

merged 1 commit into from
May 8, 2020

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented May 8, 2020

Let's move miq_tempfile.rb here, since smartstate is the only repo that uses it.

Part of the checklist for ManageIQ/manageiq-gems-pending#231

I put it under lib since the gem configuration should make it available, but I can put it directly in the OpenStackExtract/MiqOpenStackVmdirectory if you prefer.

@Fryguy
Copy link
Member

Fryguy commented May 8, 2020

@agrare Please review.

@Fryguy Fryguy added the cleanup label May 8, 2020
@miq-bot
Copy link
Member

miq-bot commented May 8, 2020

Checked commit https://github.com/djberg96/manageiq-smartstate/commit/f593a0e3239895ec2b775bba7ed0c7d1bc9b4290 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 1 offense detected

lib/OpenStackExtract/MiqOpenStackVm/MiqOpenStackInstance.rb

  • ❗ - Line 1, Col 1 - Naming/FileName - The name of this source file (MiqOpenStackInstance.rb) should use snake_case.

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this to get it extracted from gems-pending, but it looks like we could probably just stick with standard Tempfile here so maybe some follow-up refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants